Moti Asayag has posted comments on this change. Change subject: engine: Created DB function fn_get_comparable_ip_list ......................................................................
Patch Set 7: (1 inline comment) .................................................... File backend/manager/dbscripts/create_functions.sql Line 675: CREATE OR REPLACE FUNCTION fn_get_comparable_ip_list(text) RETURNS inet[] Line 676: AS $procedure$ Line 677: BEGIN Line 678: CASE Line 679: WHEN ($1 IS NULL) OR ($1 SIMILAR TO ' *') THEN wouldn't you prefer using \s as well ? Line 680: RETURN NULL; Line 681: ELSE Line 682: RETURN regexp_split_to_array(trim(both from $1), '\s+')::inet[]; Line 683: END CASE; -- To view, visit http://gerrit.ovirt.org/11432 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d29697e34c94fdc1321db2318d0e12fe27643da Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
