Maor Lipchuk has posted comments on this change.
Change subject: core: when vds isn't in storage pool, send all connection params
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java
Line 61: con.put("user", connection.getuser_name(), "");
Line 62: con.put("password", connection.getpassword(), "");
Line 63:
Line 64: // storage_pool can be null when discovering iscsi send
targets or when connecting
Line 65: // through vds which has no storage pool
Please rephrase:
storage_pool can be null when connecting through vds which has no storage pool.
this can be happened when discovering iscsi, send targets, or removing storage
domain.
Line 66: if (storage_pool == null || Config.<Boolean>
GetValue(ConfigValues.AdvancedNFSOptionsEnabled,
Line 67: storage_pool.getcompatibility_version().getValue())) {
Line 68: // For mnt_options, vfs_type, and protocol_version - if
they are null
Line 69: // or empty we should not send a key with an empty value
--
To view, visit http://gerrit.ovirt.org/11528
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67ae1418a7b879a3f0b57426d0574fcb673b2e26
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
