Tomas Jelinek has posted comments on this change.
Change subject: engine: Added IsDisplayAddressConsistentInClusterQuery
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsDisplayAddressConsistentInClusterQuery.java
Line 25: protected void executeQueryCommand() {
Line 26: GetHostsByClusterIdParameters params = new
GetHostsByClusterIdParameters(getParameters().getId());
Line 27: params.setFiltered(getParameters().isFiltered());
Line 28:
Line 29: VdcQueryReturnValue hostsReturnValue =
Backend.getInstance().RunQuery(VdcQueryType.GetHostsByClusterId, params);
Rewritten to DAO
Line 30: @SuppressWarnings("unchecked")
Line 31: List<VDS> hosts = (List<VDS>)
hostsReturnValue.getReturnValue();
Line 32:
getQueryReturnValue().setReturnValue(!isConsoleAddressPartiallyOverridden(hosts));
Line 33: }
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/IsDisplayAddressConsistentInClusterQueryTest.java
Line 17: import org.junit.runner.RunWith;
Line 18: import org.ovirt.engine.core.common.businessentities.VDS;
Line 19: import org.ovirt.engine.core.common.queries.IdQueryParameters;
Line 20:
Line 21: // this class contains only tests for the
isConsoleAddressPartiallyOverridden method
updated and changed also the name of the method on the command
Line 22: @RunWith(Theories.class)
Line 23: public class IsDisplayAddressConsistentInClusterQueryTest {
Line 24:
Line 25: private
IsDisplayAddressConsistentInClusterQuery<IdQueryParameters> command;
--
To view, visit http://gerrit.ovirt.org/11375
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1955c35a3739680f6f80c9e8b29a21a14c5b8b7a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
