Alon Bar-Lev has posted comments on this change. Change subject: vdsm/sofware: Add CentOS ......................................................................
Patch Set 1: (2 inline comments) .................................................... Commit Message Line 3: AuthorDate: 2013-01-30 10:26:16 -0500 Line 4: Commit: Douglas Schilling Landgraf <[email protected]> Line 5: CommitDate: 2013-01-30 10:26:16 -0500 Line 6: Line 7: vdsm/sofware: Add CentOS Can you please submit it with: vdsm: software: support CentOS As I use module: submodule: notation. No need for the 'Adding...' but not hurt :) Thanks! Line 8: Line 9: Adding in validation centos distro Line 10: Line 11: Change-Id: I6adc6406341ff028228f39e57d1b16e34adaa661 .................................................... File src/plugins/ovirt-host-deploy/vdsm/software.py Line 42: stage=plugin.Stages.STAGE_VALIDATION, Line 43: ) Line 44: def _validation(self): Line 45: dist, ver = platform.linux_distribution(full_distribution_name=0)[:2] Line 46: if dist == 'redhat' or dist == 'centos': Can you please: if dist in ('redhat', 'centos'): Line 47: if LooseVersion(ver) < LooseVersion('6.2'): Line 48: raise RuntimeError( Line 49: _( Line 50: 'Distribution {distribution} version {version} ' -- To view, visit http://gerrit.ovirt.org/11550 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6adc6406341ff028228f39e57d1b16e34adaa661 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
