Liron Aravot has posted comments on this change.
Change subject: core: Add storage space validator
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
minor comment..
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java
Line 43: }
Line 44:
Line 45: public ValidationResult isDomainWithinThresholds() {
Line 46: StorageDomainDynamic dynamic =
storageDomain.getStorageDynamicData();
Line 47: if (dynamic != null && dynamic.getfreeDiskInGB() >
getLowDiskSpaceThreshold()) {
when can it be null?
Line 48: return new
ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_DISK_SPACE_LOW_ON_TARGET_STORAGE_DOMAIN,
Line 49: storageName());
Line 50: }
Line 51: return ValidationResult.VALID;
--
To view, visit http://gerrit.ovirt.org/11511
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I097965d6362bd54d12860d5409f5c14d569a8968
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
