Allon Mureinik has posted comments on this change.
Change subject: core: ImagesHandler: Remove SD status validation
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
Line 547: }
Line 548:
Line 549: public static Set<Guid> getAllDomainsIds(Collection<DiskImage>
images) {
Line 550: Set<Guid> domainsIds = new HashSet<Guid>();
Line 551: for (DiskImage image : images) {
I really hate all these null safety checks.
but you're right - I'll add some javadoc there
Line 552: domainsIds.addAll(image.getstorage_ids());
Line 553: }
Line 554: return domainsIds;
Line 555: }
--
To view, visit http://gerrit.ovirt.org/11487
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id632168da64832a9c9393b81e552112240e974c0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
