Michael Kublin has uploaded a new change for review. Change subject: engine: Removing harmfull code from persitance of task to DB ......................................................................
engine: Removing harmfull code from persitance of task to DB The following code which is removed is useless, because of json serializer will not serialize parentParameters because of it is transient, but during setting them to null we can create a race which will destroy a correct value, in case if command triggered couple parallel tasks Change-Id: Ib64fd00c207eaab51585dca5634cfb15f3b83820 Signed-off-by: Michael Kublin <[email protected]> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java 1 file changed, 1 insertion(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/91/11591/1 diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java index ae4c88e..3224b24 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java @@ -88,11 +88,7 @@ } private static String serializeParameters(VdcActionParametersBase params) { - VdcActionParametersBase parentParams = params.getParentParameters(); - params.setParentParameters(null); - String jsonStr = new JsonObjectSerializer().serialize(params); - params.setParentParameters(parentParams); - return jsonStr; + return new JsonObjectSerializer().serialize(params); } } -- To view, visit http://gerrit.ovirt.org/11591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib64fd00c207eaab51585dca5634cfb15f3b83820 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
