Allon Mureinik has posted comments on this change. Change subject: core: Change CommandBase validate method to accept multiple results ......................................................................
Patch Set 1: @Tal: not exaclty before the change, we would do something like this: validate(a) && validate(b) if the 1st validate fails, the second isn't called - which means we don't even PRODUCE the b validation result. After this patch, we call validate(a,b) - we need to PRODUCE both validation results, and only short circuit on their isValid() method. -- To view, visit http://gerrit.ovirt.org/11557 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64a18ec0e6c677192dbd86bf0b38de46e539d138 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: liron aravot <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
