Michael Kublin has posted comments on this change.
Change subject: engine: fix locking issue in GlusterMultipleActionsRunner
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainsMultipleActionRunner.java
Line 59: @Override
Line 60: protected void RunCommands() {
Line 61: SortCommands();
Line 62:
Line 63: for (final CommandBase<?> command : getCommands()) {
you should also add here a following check:
if(command.getReturnValue().getCanDoAction()) {
}
better before ThreadPoolUtil.execute()
Line 64: ThreadPoolUtil.execute(new Runnable() {
Line 65:
Line 66: @Override
Line 67: public void run() {
--
To view, visit http://gerrit.ovirt.org/11597
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I100603d7155deb67bb2f0a8b451732a0003fbf55
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
