Eli Mesika has posted comments on this change.
Change subject: tools, backend: better error logging for notifierd
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/event_notification_hist.java
Line 178: .append(", sentAt=").append(sentAt)
Line 179: .append(", status=").append(status)
Line 180: .append(", subscriberId=").append(subscriberId)
Line 181: .append("]")
Line 182: .toString();
What if one of those is NULL ???
Line 183: }
....................................................
File
backend/manager/tools/engine-notifier/engine-notifier-service/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/JavaMailSender.java
Line 185: if (StringUtils.isNotBlank(messageSubject)) {
Line 186: errorMsg.append(" with subject " + messageSubject);
Line 187: }
Line 188:
Line 189: boolean firstProperty = true;
Please encapsulate this block in a method
Line 190: for (String key :
session.getProperties().stringPropertyNames()) {
Line 191: errorMsg.append(firstProperty ? " (connection
properties: " : ", ");
Line 192: firstProperty = false;
Line 193:
errorMsg.append(key).append("=").append(session.getProperties().getProperty(key));
....................................................
Commit Message
Line 3: AuthorDate: 2013-01-29 19:59:33 -0500
Line 4: Commit: Noam Slomianko <[email protected]>
Line 5: CommitDate: 2013-01-30 16:48:31 +0200
Line 6:
Line 7: tools, backend: better error logging for notifierd
s/notifird/notifier
Line 8:
Line 9: If email fails to send, log mail sender properties.
Line 10: Log notifications added to the db
Line 11:
--
To view, visit http://gerrit.ovirt.org/11554
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa11e841c4724fda310fff63c9783928465d9635
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
