Daniel Erez has posted comments on this change.
Change subject: userportal, webadmin: Show warning for non-exportable disks
......................................................................
Patch Set 4: (1 inline comment)
Looks good! Just one style issue (inline)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.ui.xml
Line 41: <e:EntityModelTextBoxEditor
ui:field="descriptionEditor" />
Line 42: <e:ListModelListBoxEditor ui:field="clusterEditor" />
Line 43: <e:ListModelListBoxEditor ui:field="quotaEditor" />
Line 44: <g:Label ui:field="disksAllocationLabel"
addStyleNames="{style.disksAllocationLabel}" />
Line 45: <w:DisksAllocationView ui:field="disksAllocationView"
listHeight="170px" listWidth="445px"
addStyleNames="{style.disksAllocationPanel}" />
listWidth should be increased to 475px to compensate on the '460px -> 490px'
change in VmMakeTemplatePopupView.java (or just revert the change...)
Line 46: <g:VerticalPanel>
Line 47: <e:EntityModelCheckBoxEditor
ui:field="isTemplatePublicEditor"
addStyleNames="{style.isTemplatePublicEditor}" />
Line 48: <g:FlowPanel ui:field="messagePanel"
addStyleNames="{style.messagePanel}">
Line 49: </g:FlowPanel>
--
To view, visit http://gerrit.ovirt.org/11144
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a183931e36ccd4668225ad206edc4a5e58795e3
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Libor Spevak <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
