Michael Pasternak has posted comments on this change.
Change subject: restapi : malformated guid's cause http 500 (#902073)
......................................................................
Patch Set 1: (1 inline comment)
not sure i like this concept,
1. overhead of every method check (deep search)
2. all guids will be validated including irrelevant to the context
3. not all IDs are UUIDs,
i think better solution is moving MalformedIdException from jaxrs to the
restapi-types and throwing MalformedIdException instead of
IllegalArgumentException from there,
then it will be warped to the BR-400 by ServerInterceptor in the jaxrs
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java
Line 324: List<String> guids = null;
Line 325: try {
Line 326: guids = (new GuidExtractor()).getGuidsInObject(model);
Line 327: } catch(Exception e) {
Line 328: System.out.println("Unable to get GUIDs from model");
log error?
Line 329: }
Line 330: if (guids != null) {
Line 331: for (String guid : guids) {
Line 332: asGuid(guid);
--
To view, visit http://gerrit.ovirt.org/11581
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I55e7975112ea1372ca4018d5351b70b073928e0d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
