Yair Zaslavsky has uploaded a new change for review. Change subject: tools: In case ldapServers is used, useDnsLookup should be ignored ......................................................................
tools: In case ldapServers is used, useDnsLookup should be ignored As a part of introduction of -ldapSerers option in manage-domains, useDnsLookup flag must be ignored, so KDC list appears in krb5.conf file and the KDCs will be selected in the order of appearance in krb5.conf This patch has an assumption in which ldap servers serve as KDC. Bug-Url: https://bugzilla.redhat.com/894681 Change-Id: I808fe02553b5554b76f08b43a30fb0ffd7d99931 Signed-off-by: Yair Zaslavsky <[email protected]> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KrbConfCreator.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/04/11704/1 diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KrbConfCreator.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KrbConfCreator.java index 5f421ce..842025d 100644 --- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KrbConfCreator.java +++ b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KrbConfCreator.java @@ -46,7 +46,7 @@ } public KrbConfCreator(String domains, boolean useDnsLookup, Map<String, List<String>> ldapServersPerGSSAPIDomains) throws Exception { - this.useDnsLookup = useDnsLookup; + this.useDnsLookup = useDnsLookup && ( ldapServersPerGSSAPIDomains == null || ldapServersPerGSSAPIDomains.size() == 0 ); this.ldapServersPerGSSAPIDomains = ldapServersPerGSSAPIDomains; loadSourceFile(); extractRealmsFromDomains(domains); -- To view, visit http://gerrit.ovirt.org/11704 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I808fe02553b5554b76f08b43a30fb0ffd7d99931 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
