Vojtech Szocs has posted comments on this change.
Change subject: Allow plugins to specify if they want their dynamic tabs and
sub tabs right or left justified.
......................................................................
Patch Set 1:
Nice patch Spenser! I have only one comment: maybe we should avoid duplicating
addMainTab/addSubTab function declarations within pluginApi object, e.g. have
one version of each function that works with optional arguments such as tab
alignment.
I'm thinking of an API like this:
api.addMainTab('My Tab', 'my-tab', contentUrl); // no align specified, defaults
to align=LEFT
api.addMainTab('My Tab', 'my-tab', contentUrl, { align: 'RIGHT' }); // align
specified via (null-able) object containing optional arguments
What do you think?
--
To view, visit http://gerrit.ovirt.org/11273
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd6929538fd106d0c54d162dfd21f8946254ce5f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Spenser Shumaker <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Keith Robertson <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
