Asaf Shakarchi has uploaded a new change for review. Change subject: webadmin: Check fir NPE in AsyncDataProvider:GetInterfaceOptionsForEditNetwork ......................................................................
webadmin: Check fir NPE in AsyncDataProvider:GetInterfaceOptionsForEditNetwork There's a possible branch of statement, that if executed a null value will be dereferenced. this patch verifies that the var is not null before using it. Change-Id: Iba10d8a40e414e18fa6a87024dad9e1ed6a69bc7 Signed-off-by: Asaf Shakarchi <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/22/11722/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java index 1b0e739..4490966 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java @@ -2466,7 +2466,8 @@ }else{ // the vlanParent should already be in ifacesOptions // (since it has no network_name or bond_name). - defaultInterfaceName.append(vlanParent.getName()); + if (vlanParent != null) + defaultInterfaceName.append(vlanParent.getName()); asyncQuery.asyncCallback.OnSuccess(asyncQuery.Model, ifacesOptions); } } -- To view, visit http://gerrit.ovirt.org/11722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iba10d8a40e414e18fa6a87024dad9e1ed6a69bc7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
