Asaf Shakarchi has uploaded a new change for review. Change subject: api: Current:currents needs to be static to avoid deadly embrace. ......................................................................
api: Current:currents needs to be static to avoid deadly embrace. Discovered by findbugs: org.ovirt.engine.api.common.invocation.Current$1 needs to be _static_ to avoid a deadly embrace with org.ovirt.engine.api.common.invocation.Current.currentsFirst. By definition: ThreadLocal instances are typically private static fields in classes that wish to associate state with a thread. Change-Id: I86516044e758aa526f7bab570d41567b35176029 Signed-off-by: Asaf Shakarchi <[email protected]> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/invocation/Current.java 1 file changed, 1 insertion(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/19/11719/1 diff --git a/backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/invocation/Current.java b/backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/invocation/Current.java index 22dbdfa..c74ba47 100644 --- a/backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/invocation/Current.java +++ b/backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/invocation/Current.java @@ -29,11 +29,7 @@ @ServerInterceptor public class Current implements PostProcessInterceptor { - private ThreadLocal<Map<Class<?>, Object>> currents; - - public Current() { - currents = new ThreadLocal<Map<Class<?>, Object>>(); - } + private static ThreadLocal<Map<Class<?>, Object>> currents = new ThreadLocal<Map<Class<?>, Object>>(); @Override public void postProcess(ServerResponse response) { -- To view, visit http://gerrit.ovirt.org/11719 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I86516044e758aa526f7bab570d41567b35176029 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
