Allon Mureinik has posted comments on this change.
Change subject: core: Removed deprecated StringBuilderCompat class
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
Shouldn't you also remove
frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/StringBuilderCompat.java?
....................................................
File
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxContainer.java
Line 11: private final String mOrigText;
Line 12: private final LinkedList<SyntaxObject> mObjList = new
LinkedList<SyntaxObject>();
Line 13: private final List<String> mCurrentCompletions = new
ArrayList<String>();
Line 14:
Line 15: protected static final String LINE_SEPARATOR = "\n";
1. why not private?
2. why not Sytem.getProperty("line.separator")?
Line 16: private boolean mValid = false;
Line 17: private SyntaxError mError = SyntaxError.NO_ERROR;
Line 18: private final int[] mErrorPos = new int[2];
Line 19: private int privateMaxCount;
--
To view, visit http://gerrit.ovirt.org/11660
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5192154dc008c18c4169020c8bfe71946c3c8716
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
