Arik Hadas has posted comments on this change. Change subject: engine: Added infrastructure for providing a canDoactions in case of locks ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java Line 13: STORAGE, Line 14: REGISTER_VDS, Line 15: VM_SNAPSHOTS, Line 16: GLUSTER, Line 17: USER_VM_POOL; why did you add that group in this patch? Line 18: .................................................... File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/lock/LockManager.java Line 12: Line 13: /** Line 14: * The following method will try to acquire provided lock Line 15: * @param lock Line 16: * @return true - in case of locked was acquired , false - otherwise the javadoc should be updated Line 17: */ Line 18: Pair<Boolean, Set<String>> acquireLock(EngineLock lock); Line 19: Line 20: /** -- To view, visit http://gerrit.ovirt.org/11738 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87698da36ddb6e7556e98612d299da68f2eb53dc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
