Maor Lipchuk has posted comments on this change.
Change subject: core: Change VmPool method names to fit the standard
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDAODbFacadeImpl.java
Line 191: entity.setVdsGroupId(Guid.createGuidFromString(rs
Line 192: .getString("vds_group_id")));
Line 193: entity.setVdsGroupName(rs.getString("vds_group_name"));
Line 194:
entity.setAssignedVmsCount(rs.getInt("assigned_vm_count"));
Line 195: entity.setRunningVmsCount(rs.getInt("vm_running_count"));
Do we want to step out of our convention? The java field name is now not
compatible with the field name of the DB.
Line 196: return entity;
Line 197: }
Line 198: }
Line 199:
--
To view, visit http://gerrit.ovirt.org/11715
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida3b96f501074e5b8198912d40f21224a3c90832
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
