Michael Kublin has posted comments on this change.
Change subject: WIP: working CDI solution for backend
......................................................................
Patch Set 4: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
Line 100: public static BackendInternal getInstance() {
Line 101: return EjbUtils.findBean(BeanType.BACKEND,
BeanProxyType.LOCAL);
Line 102: }
Line 103:
Line 104: @Produces
If it is here, I think we should also marked it with annotation
@ExcludeClassInterceptors, but I don't think that getDbFacade() should be part
of bean interface
Line 105: public DbFacade getDbFacade() {
Line 106: return DbFacade.getInstance();
Line 107: }
Line 108:
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1366:
Line 1367: @Inject
Line 1368: private BackendInternal backend;
Line 1369:
Line 1370: @Inject
db should be moved to parent class. Which is AuditLogableBase
Line 1371: DbFacade db;
Line 1372:
Line 1373: protected EngineLock getLock() {
Line 1374: return commandLock;
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InjectionHelper.java
Line 3: import javax.enterprise.inject.spi.AnnotatedType;
Line 4: import javax.enterprise.inject.spi.BeanManager;
Line 5: import javax.inject.Inject;
Line 6:
Line 7:
why I need these class?
Line 8: public class InjectionHelper {
Line 9:
Line 10: @Inject
Line 11: private BeanManager manager;
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/interfaces/BackendInternal.java
Line 77: */
Line 78: ArrayList<VdcReturnValueBase>
runInternalMultipleActions(VdcActionType actionType,
Line 79: ArrayList<VdcActionParametersBase> parameters,
Line 80: ExecutionContext executionContext);
Line 81:
also why getDBFacade() is moved to interface of beean?
Line 82: DbFacade getDbFacade();
Line 83:
--
To view, visit http://gerrit.ovirt.org/5575
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f604ff91847b698efe84a09f724ba0492a672c1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
