Vojtech Szocs has posted comments on this change.
Change subject: [WIP] webadmin: UI plugin dialog API improved
......................................................................
Patch Set 1:
I've implemented all showDialog TODO items, need to test them carefully before
submitting new patch set.
Example of new showDialog function with all supported arguments:
api.showDialog('My Dialog', 'my-dialog', 'http://www.example.com/', '800px',
'600px', {
resizeEnabled: true, // default:false
closeIconVisible: true, // default:false
closeOnEscKey: true, // default:false
buttons: [ // default:[]
{
getLabel: function() { return 'Show Alert'; },
onClick: function() { alert('Bump!'); }
},
{
getLabel: function() { return 'Close Dialog'; },
onClick: function() { api.closeDialog('my-dialog'); }
}
]
});
--
To view, visit http://gerrit.ovirt.org/11717
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4654a25bed7122c45d432e3860ed710fa4ca3dd9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Chris Morrissey <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Keith Robertson <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Spenser Shumaker <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches