Yair Zaslavsky has posted comments on this change.
Change subject: core: StorageHelper class for GlusterFS.
......................................................................
Patch Set 9: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GlusterFsStorageHelper.java
Line 4: import org.ovirt.engine.core.utils.log.Log;
Line 5:
Line 6: /**
Line 7: * Storage helper for Posix FS connections
Line 8: */
If StorageType is GLUSTERFS than this should be the prefix of the Class name
(see
POSIXFSStorageHelper for example).
Line 9: public class GlusterFsStorageHelper extends BaseFsStorageHelper {
Line 10:
Line 11: protected Log getLog() {
Line 12: return log;
--
To view, visit http://gerrit.ovirt.org/8834
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5360ac7b3ccc02a3ec70e217bc7a1c3aa7d24600
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
