Allon Mureinik has uploaded a new change for review. Change subject: core: ActivateStorageDomain - unwrap useless less ......................................................................
core: ActivateStorageDomain - unwrap useless less Unwrapped a useless else block, since the if does not terminate normally anyway - it early returns. Change-Id: I333cbbaec533579e0f437bb3fbc28f4cb2ffbfe0 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/29/11829/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java index a3725d3..ba9c380 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java @@ -18,9 +18,9 @@ import org.ovirt.engine.core.common.action.VdcActionType; import org.ovirt.engine.core.common.businessentities.StorageDomainStatus; import org.ovirt.engine.core.common.businessentities.StorageDomainType; +import org.ovirt.engine.core.common.businessentities.StoragePoolIsoMap; import org.ovirt.engine.core.common.businessentities.StoragePoolIsoMapId; import org.ovirt.engine.core.common.businessentities.StoragePoolStatus; -import org.ovirt.engine.core.common.businessentities.StoragePoolIsoMap; import org.ovirt.engine.core.common.locks.LockingGroup; import org.ovirt.engine.core.common.vdscommands.ActivateStorageDomainVDSCommandParameters; import org.ovirt.engine.core.common.vdscommands.VDSCommandType; @@ -118,10 +118,9 @@ if (getParameters().isRunSilent()) { return getSucceeded() ? AuditLogType.USER_ACTIVATED_STORAGE_DOMAIN_ASYNC : AuditLogType.USER_ACTIVATE_STORAGE_DOMAIN_FAILED_ASYNC; - } else { - return getSucceeded() ? AuditLogType.USER_ACTIVATED_STORAGE_DOMAIN - : AuditLogType.USER_ACTIVATE_STORAGE_DOMAIN_FAILED; } + return getSucceeded() ? AuditLogType.USER_ACTIVATED_STORAGE_DOMAIN + : AuditLogType.USER_ACTIVATE_STORAGE_DOMAIN_FAILED; } @Override -- To view, visit http://gerrit.ovirt.org/11829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I333cbbaec533579e0f437bb3fbc28f4cb2ffbfe0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
