Sandro Bonazzola has posted comments on this change.

Change subject: packaging: Application Mode option in installer
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

Isn't this cherry-picked from master?

....................................................
File packaging/fedora/setup/output_messages.py
Line 144: INFO_CONF_PARAMS_DB_PASSWD_USAGE="Password for the local database 
administrator"
Line 145: INFO_CONF_PARAMS_DB_PASSWD_PROMPT="Enter a password for a local %s DB 
admin user (%s)" % (basedefs.APP_NAME, basedefs.DB_USER)
Line 146: INFO_CONF_PARAMS_PASSWD_CONFIRM_PROMPT="Confirm password"
Line 147: INFO_CONF_PARAMS_APPLICATION_MODE_USAGE="Application Mode"
Line 148: INFO_CONF_PARAMS_APPLICATION_MODE_PROMPT="The engine can be 
configured to present the UI in three different application modes. virt [Manage 
virtualization only], gluster [Manage gluster storage only], and both [Manage 
virtualization as well as gluster storage]"
This line is too long.
Line 149: 
Line 150: #Remote DB interaction
Line 151: INFO_CONF_PARAMS_REMOTE_DB_USAGE="Select local or remote DB server"
Line 152: INFO_CONF_PARAMS_REMOTE_DB_PROMPT="Enter DB type for installation"


--
To view, visit http://gerrit.ovirt.org/11801
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c958205727905d00f6e407779ee64f5c5eb5a1a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: engine_3.2
Gerrit-Owner: Aravinda VK <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Aravinda VK <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to