Tal Nisan has posted comments on this change.
Change subject: core: Added RegisterDiskCommand and GetUnregisteredDisksQuery
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredDiskQuery.java
Line 55: storagePoolId, storageDomainId, diskId,
volumeId);
Line 56: VDSReturnValue imageInfoReturn =
backend.getResourceManager().RunVdsCommand(
Line 57: VDSCommandType.GetImageInfo,
imageInfoParameters);
Line 58:
Line 59: if (imageInfoReturn.getSucceeded()) {
Fede, you really hate indentation, eh? :)
Line 60: DiskImage newDiskImage = (DiskImage)
imageInfoReturn.getReturnValue();
Line 61: // The disk image won't have an interface set on
it. Set it to IDE by default. When the
Line 62: // disk is attached to a VM, its interface can be
changed to the appropriate value for that VM.
Line 63: newDiskImage.setDiskInterface(DiskInterface.IDE);
--
To view, visit http://gerrit.ovirt.org/11783
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82de498fd9a8e25ed9e1dc5776f2fdf0c35b46da
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Chris Morrissey <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Chris Morrissey <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
