Allon Mureinik has posted comments on this change.
Change subject: engine: check if host exists with same name
......................................................................
Patch Set 10: Looks good to me, but someone else must approve
(1 inline comment)
@laszlo - please fix the logging issue in RegisterVdsQuery, rebase, and verify,
and lets get this merged.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
Line 432: List<String> allHostNames = getAllHostNames(vdsDAO.getAll());
Line 433: boolean hostExistInDB = hostToRegister != null;
Line 434:
Line 435: if (host != null) {
Line 436: log.debugFormat(
You won't be able to log here.
This should be "found VDS with the same name {0}.
Line 437: "found a VDS with the same name {1}. Will try to
register with a new name",
Line 438: getParameters().getVdsName());
Line 439:
Line 440: String nameToRegister = getParameters().getVdsName();
--
To view, visit http://gerrit.ovirt.org/10910
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4791d49b128126269d9b2b0c2e9bb35debf5a7ec
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
