Mike Kolesnik has posted comments on this change.
Change subject: engine: Add validator for NetworkCluster
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterValidator.java
Line 21: * @param networkName
Line 22: * The network's name.
Line 23: * @return Error iff the management network attachment is not
valid.
Line 24: */
Line 25: public ValidationResult managementNetworkAttachment(String
networkName) {
Actually, no, since if you check what is the NetworkCluster class that is being
validated you'll see that it has no way to check if it's management network.
Hence, this method can't be responsible for checking that fact.
Line 26: return networkCluster.isRequired() ? ValidationResult.VALID
Line 27: : new
ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_MANAGEMENT_NETWORK_REQUIRED,
Line 28: String.format(NETWORK_NAME_REPLACEMENT,
networkName));
Line 29: }
--
To view, visit http://gerrit.ovirt.org/11836
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba58dfbd9950176ba26790ff6a50244d554fd9b3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
