Muli Salem has uploaded a new change for review. Change subject: core: Fix Device and Network Unit Test ......................................................................
core: Fix Device and Network Unit Test Change-Id: Ifde7b681e94328f4b6c0a63cff48bc588c0cddb6 Bug-Url: https://bugzilla.redhat.com/903572 Signed-off-by: Muli Salem <[email protected]> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkDaoTest.java 2 files changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/75/11875/1 diff --git a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDAOTest.java b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDAOTest.java index 8aa206d..2c81121 100644 --- a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDAOTest.java +++ b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDAOTest.java @@ -23,7 +23,7 @@ private static final Guid EXISTING_VM_ID = new Guid("77296e00-0cad-4e5a-9299-008a7b6f4355"); private static final Guid EXISTING_DEVICE_ID = new Guid("e14ed6f0-3b12-11e1-b614-63d00126418d"); - private static final int TOTAL_DEVICES = 8; + private static final int TOTAL_DEVICES = 9; private static final int TOTAL_DEVICES_FOR_EXISTING_VM = 2; diff --git a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkDaoTest.java b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkDaoTest.java index 778b04a..a9b594a 100644 --- a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkDaoTest.java +++ b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkDaoTest.java @@ -20,7 +20,8 @@ private Guid cluster; private Guid datacenter; private Network new_net; - final static private String EXISTING_NETWORK_NAME = "engine"; + private static final String EXISTING_NETWORK_NAME = "engine"; + private static final int NUM_OF_NETWORKS = 4; @Override public void setUp() throws Exception { @@ -88,7 +89,7 @@ List<Network> result = dao.getAll(); assertNotNull(result); - assertEquals(3, result.size()); + assertEquals(NUM_OF_NETWORKS, result.size()); } /** -- To view, visit http://gerrit.ovirt.org/11875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifde7b681e94328f4b6c0a63cff48bc588c0cddb6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
