Tal Nisan has posted comments on this change.
Change subject: webadmin: move-copy disks - inactive domains indication
......................................................................
Patch Set 1: Looks good to me, approved
(2 inline comments)
Some minor comments, please address them
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/MoveOrCopyDiskModel.java
Line 181: sortDisks();
Line 182: postCopyOrMoveInit(showWarning);
Line 183: }
Line 184:
Line 185: private void addProhibitionReasons(DiskModel disk, boolean
isDiskBasedOnTemplate, boolean noSources, boolean noTargets) {
Replace method name to updateChangeability, that's the main action here, the
prohibition reason is just an appendix to that
Line 186: disk.getStorageDomain().setIsChangable(!noTargets);
Line 187: disk.getSourceStorageDomain().setIsChangable(!noSources);
Line 188: disk.getSourceStorageDomainName().setIsChangable(!noSources);
Line 189:
disk.getStorageDomain().getChangeProhibitionReasons().add(isDiskBasedOnTemplate
?
....................................................
File
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
Line 813: String diskExistsOnAllActiveStorageDomainsMsg();
Line 814:
Line 815: @DefaultStringValue("The Template that the VM is based on does
not exist on any active Storage Domain")
Line 816: String noActiveStorageDomainWithTemplateMsg();
Line 817:
Is it a trailing whitespace? If so please remove it
Line 818: @DefaultStringValue("Warning: Some of the disks cannot be moved")
Line 819: String cannotMoveDisks();
Line 820:
Line 821: @DefaultStringValue("Warning: Some of the disks cannot be copied")
--
To view, visit http://gerrit.ovirt.org/11873
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1c17bbcdfa9c2358a17b297ef99a94254f68132
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
