Alissa Bonas has posted comments on this change.
Change subject: engine: Preventing running host monitor during activation of
host operation
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java
Line 55: new
EngineLock(Collections.singletonMap(getParameters().getVdsId().toString(),
Line 56: LockingGroup.VDS_INIT.name()), null);
Line 57: log.info("Before acquiring lock in order to prevent
monitoring");
Line 58: getLockManager().acquireLockWait(monitoring_lock);
Line 59: log.info("Lock acquired, from now a monitoring of host will be
skipped");
It's better to add to log statement which host's (id/name/ip etc.) monitoring
will be skipped, otherwise the logging message is too general and not helpful
to whoever reads the log.
Line 60: try {
Line 61: final VDS vds = getVds();
Line 62:
ExecutionHandler.updateSpecificActionJobCompleted(vds.getId(),
VdcActionType.MaintananceVds, false);
Line 63: TransactionSupport.executeInNewTransaction(new
TransactionMethod<Void>() {
--
To view, visit http://gerrit.ovirt.org/11885
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If7f5eed741ca392ed7144934c539d2aa70744431
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
