Allon Mureinik has uploaded a new change for review. Change subject: core: MapEntry iterator in PostgresDbEngineDialect ......................................................................
core: MapEntry iterator in PostgresDbEngineDialect Iterated over the entries in extractOutputParameters(CallableStatement,List) instead of the keySet for better performance. Note that this addressed the FindBugs issue of WMI_WRONG_MAP_ITERATOR for this class. Change-Id: I42c320fd77c485b787e94899c4944c39d6fddec8 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/PostgresDbEngineDialect.java 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/09/11909/1 diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/PostgresDbEngineDialect.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/PostgresDbEngineDialect.java index 9943404..8f0ff1d 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/PostgresDbEngineDialect.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/PostgresDbEngineDialect.java @@ -52,12 +52,12 @@ Map<String, Object> outputParameters = super.extractOutputParameters(cs, parameters); Map<String, Object> returnMap = new HashMap<String, Object>(outputParameters.size()); - for (String parameter : outputParameters.keySet()) { - + for (Map.Entry<String, Object> outputEntry : outputParameters.entrySet()) { // Get the value before we change the key (otherwise we won't be able to get it later when we need it). - Object value = outputParameters.get(parameter); + String parameter = outputEntry.getKey(); + Object value = outputEntry.getValue(); if (parameter != null && parameter.length() > PREFIX.length() && parameter.startsWith(PREFIX)) { - parameter = ((String) parameter).substring(PREFIX.length()); + parameter = parameter.substring(PREFIX.length()); } returnMap.put(parameter, value); -- To view, visit http://gerrit.ovirt.org/11909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I42c320fd77c485b787e94899c4944c39d6fddec8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
