Michael Kublin has posted comments on this change.

Change subject: core: ADL - remove redundant null check
......................................................................


Patch Set 1: Looks good to me, approved

(1 inline comment)

....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
Line 853:                 if (!"".equals(loggerString)) {
Line 854:                     log.infoFormat(loggerString, resolvedMessage);
Line 855:                 }
Line 856:             }
Line 857:         } else {
It can not. My mistake
Line 858:             log.infoFormat("No string for {0} type. Use default Log", 
auditLogable.getAuditLogTypeValue());
Line 859:         }
Line 860:     }
Line 861: 


--
To view, visit http://gerrit.ovirt.org/11904
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I03de66e7494d1b191ad7c71c726bff4aebc570c1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to