Juan Hernandez has posted comments on this change. Change subject: packaging: configuring ovirt-engine on upgrade ......................................................................
Patch Set 4: (1 inline comment) .................................................... File packaging/fedora/setup/common_utils.py Line 1665: ) Line 1666: xpath = xmlObj.xpathEval( Line 1667: "//datasource:subsystem/datasource:datasources/" Line 1668: "datasource:datasource[@jndi-name='java:/ENGINEDataSource']/" Line 1669: "connnection-property[@name='ssl']" I think that "connection-property" has to be prefixed with "datasource:", otherwise it will never match. Line 1670: ) Line 1671: Line 1672: if xpath and xpath[0]: Line 1673: # Means ssl mode was set -- To view, visit http://gerrit.ovirt.org/11825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf596fa9ecaae5ccc6580c19563b21f706d11cfc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
