Maor Lipchuk has posted comments on this change.
Change subject: core : attach storage domain should attempt to activate
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java
Line 106: }
Line 107: return null;
Line 108: }
Line 109: });
Line 110: attemptToActivateDomain();
If activate will fail, don't we want to fail the action? or print an audit log?
Line 111: setSucceeded(true);
Line 112: }
Line 113: }
Line 114: }
Line 118: protected void attemptToActivateDomain() {
Line 119: StorageDomainPoolParametersBase activateParameters = new
StorageDomainPoolParametersBase(getStorageDomain().getId(),
Line 120: getStoragePool().getId());
Line 121: Backend.getInstance()
Line 122:
.runInternalAction(VdcActionType.ActivateStorageDomain, activateParameters);
We should print the CDA messages if activate storage domain will fail.
Line 123: }
Line 124:
Line 125: @Override
Line 126: public AuditLogType getAuditLogTypeValue() {
....................................................
Commit Message
Line 5: CommitDate: 2013-02-11 16:03:48 +0200
Line 6:
Line 7: core : attach storage domain should attempt to activate
Line 8:
Line 9: When attaching storage domain to pool, attemp to activate it after
/s/attemp/attempt
Line 10: attaching.
Line 11:
Line 12: Change-Id: I4e6f21b350520aef47be0ba282a3074a3b3c5119
--
To view, visit http://gerrit.ovirt.org/11928
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e6f21b350520aef47be0ba282a3074a3b3c5119
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
