Doron Fediuck has posted comments on this change.
Change subject: tools: engine-notifier accept special chars
......................................................................
Patch Set 2: (1 inline comment)
Acceptable, just make sure the commit message says config file expects
key-value.
Also please quote tested lines (see inside).
....................................................
File
backend/manager/tools/engine-notifier/engine-notifier-resources/src/main/resources/notifier.sh
Line 44: old_IFS=$IFS
Line 45: IFS=$'\n'
Line 46: for line in `cat $CONF_FILE`:
Line 47: do
Line 48: if [[ $line == \#* ]] || [[ ${line}x == "x" ]] ; then
Please use "\#*".
Line 49: #if comment or empty, skip
Line 50: continue
Line 51: else
Line 52: declare "$line"
--
To view, visit http://gerrit.ovirt.org/10704
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e6419a225bd02edaf1db38a2025dee74761ddf2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
