Greg Padgett has uploaded a new change for review.

Change subject: webadmin: validation for "Use Host CPU" setting
......................................................................

webadmin: validation for "Use Host CPU" setting

To enable CPU Host, one of the two no-migrate flags for a VM (run on
selected host, or allow migration only upon admin request) must be
enabled.  If CPU Host was disabled along with the no-migrate flag in
the same save action, the new CPU Host value was not propagated to the
VM object which caused a validation error.

This patch propagates the CPU Host value to the VM object, allowing
the CPU Host flag and no-migrate flag to be disabled in the same edit.

Change-Id: I786a725f6ff20e64d2d094b4c8c183c907978229
Bug-Url: https://bugzilla.redhat.com/905843
Signed-off-by: Greg Padgett <[email protected]>
---
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/94/11994/1

diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
index 6b0ff36..591867b 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
@@ -2462,6 +2462,10 @@
             
getcurrentVm().setMigrationSupport(MigrationSupport.IMPLICITLY_NON_MIGRATABLE);
             getcurrentVm().setUseHostCpuFlags((Boolean) 
model.getHostCpu().getEntity());
         }
+        else
+        {
+            getcurrentVm().setUseHostCpuFlags(Boolean.FALSE);
+        }
 
         if (model.getIsNew())
         {


--
To view, visit http://gerrit.ovirt.org/11994
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I786a725f6ff20e64d2d094b4c8c183c907978229
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to