Sahina Bose has posted comments on this change.
Change subject: webadmin: using search backend to find Up server in cluster
......................................................................
Patch Set 2: (1 inline comment)
Can GetUpHostListByCluster be reused?
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
Line 1127: new AddedGlusterServersParameters(clusterId,
isFingerprintRequired),
Line 1128: aQuery);
Line 1129: }
Line 1130:
Line 1131: public static void isClusterHasAnyUpHost(AsyncQuery aQuery,
String clusterName) {
How about IsAnyHostUpInCluster?
Also, there is a method in this file - GetUpHostListByCluster which is similar
except the num of results returned. Can it be reused?
Line 1132: aQuery.converterCallback = new IAsyncConverter() {
Line 1133: @Override
Line 1134: public Object Convert(Object source, AsyncQuery
_asyncQuery)
Line 1135: {
--
To view, visit http://gerrit.ovirt.org/11995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2ba449d2fa43d0c2e510ec4d0b51d3dc359b6ae
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
