Moti Asayag has posted comments on this change.
Change subject: engine: NetworkClusterValidator refactoring
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterValidator.java
Line 8:
Line 9: /**
Line 10: * Validator class for {@link NetworkCluster} instances.
Line 11: */
Line 12: public class NetworkClusterValidator extends NetworkValidator {
I don't think this inheritance has a strong argument.
I think the answer for does the relation "NetworkClusterValidator is a
NetworkValiadtor" hold is no.
NetworkCluster and Network are different entities (with some relation between
them).
I can't see how/why the behaviour of NetworkValiadtor would be extended by
NetworkClusterValidator.
The NetworkCluster carries the attachment information and not the network data.
Line 13: protected static final String NETWORK_NAME_REPLACEMENT =
"$NetworkName %s";
Line 14: protected NetworkCluster networkCluster;
Line 15:
Line 16: public NetworkClusterValidator(Network network, NetworkCluster
networkCluster) {
--
To view, visit http://gerrit.ovirt.org/11949
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id405292de1233fe8fc546e47baa92f644d591638
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
