Liron Aravot has posted comments on this change.
Change subject: core: TimeoutBase: Prevent updating mutable Date
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
Line 871: Math.max(auditLogable.getEventFloodInSec(), 30) //
Min duration for External Events is 30 sec
Line 872: :
Line 873: logType.getDuplicateEventsIntervalValue();
Line 874: if (duplicateEventsIntrvalValue > 0) {
Line 875: auditLogable.setEndTime(System.currentTimeMillis() +
logType.getDuplicateEventsIntervalValue());
shouldn't you convert the logType.getDuplicateEventsIntervalV
value to millis?
Line 876:
auditLogable.setTimeoutObjectId(composeObjectId(auditLogable, logType));
Line 877: }
Line 878: }
Line 879:
--
To view, visit http://gerrit.ovirt.org/11897
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd77e518369fa25bfe684d249d12e0f8e2bb1a0f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
