Mike Kolesnik has posted comments on this change.
Change subject: engine: Refactoring in unassign network from cluster command
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java
Line 33: @Override
Line 34: protected boolean canDoAction() {
Line 35: DetachNetworkClusterValidator validator =
Line 36: new
DetachNetworkClusterValidator(getParameters().getNetwork(),
getParameters().getNetworkCluster());
Line 37: return validate(validator.notManagementNetwork())
This is not the same error message.
Frankly, I prefer this one (NETWORK_CANNOT_REMOVE_MANAGEMENT_NETWORK) since
it's more verbose.
Line 38: && validate(validator.clusterNetworkNotUsedByVms())
Line 39: &&
validate(validator.clusterNetworkNotUsedByTemplates());
Line 40: }
Line 41:
Line 75: VdcBllMessages.VAR__ENTITIES__VMS);
Line 76: }
Line 77:
Line 78: public ValidationResult clusterNetworkNotUsedByTemplates() {
Line 79: return
networkNotUsed(getVmTemplateDAO().getAllForVdsGroup(networkCluster.getClusterId()),
This returns all templates, regardless of whether they use the network or not.
I'm quite sure you need to check if the network is used on the templates or not.
Line 80: VdcBllMessages.VAR__ENTITIES__VM_TEMPLATES);
Line 81: }
Line 82: }
--
To view, visit http://gerrit.ovirt.org/10683
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I127615d9144084ad093ac1d20841979be8163a12
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
