Michael Pasternak has posted comments on this change.
Change subject: restapi : vm/template Import candidates should have /disks
(#829672)
......................................................................
Patch Set 6: Looks good to me, approved
(2 inline comments)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplateResource.java
Line 75: protected VmTemplate getEntity() {
Line 76: if (template != null) {
Line 77: return template;
Line 78: }
Line 79: for (VmTemplate entity : parent.getEntitiesFromExportDomain())
{
despite it's not related to this patch, i'd preffer using direct query rather
than looping over all entities on SD (but query is missing)
Line 80: if (guid.equals(entity.getId())) {
Line 81: template = entity;
Line 82: return entity;
Line 83: }
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResource.java
Line 84: protected org.ovirt.engine.core.common.businessentities.VM
getEntity() {
Line 85: if (vm != null) {
Line 86: return vm;
Line 87: }
Line 88: for (org.ovirt.engine.core.common.businessentities.VM entity :
parent.getEntitiesFromExportDomain()) {
despite it's not related to this patch, i'd preffer using direct query rather
than looping over all entities on SD (but query is missing)
Line 89: if (guid.equals(entity.getId())) {
Line 90: vm = entity;
Line 91: return entity;
Line 92: }
--
To view, visit http://gerrit.ovirt.org/11126
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I83fd4b046f72f73bb516615137522ac40028a7f0
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
