Michael Pasternak has posted comments on this change. Change subject: restapi : Add /clusters sub-collection under /datacenters/xxx(#674521) ......................................................................
Patch Set 5: i couldn't see you implementing BackendDataCenterClusterResource, it's true that you extend BackendClustersResource by BackendDataCenterClustersResource and it will return BackendClusterResource on /api/datacenetrs/xxx/clusters/yyy, but it capable to return clusters not belong to the given (xxx) datacenter as it uses generic query for clusters, while you should be returning only clusters from the xxx DC or 404, you need to implement BackendDataCenterClusterResource extending BackendClusterResource and override get() that will use GetVdsGroupsByStoragePoolId query -- To view, visit http://gerrit.ovirt.org/11618 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b27ef501324d890efbe0e8b914d9db47653f146 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
