Michael Pasternak has posted comments on this change.
Change subject: restapi : close api gaps for operation using id and name
(#890329)
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
please also submit a patch to the master (otherwise you causing regression in
the 3.3)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java
Line 77: public Host update(Host incoming) {
Line 78: validateEnums(Host.class, incoming);
Line 79: QueryIdResolver<Guid> hostResolver = new
QueryIdResolver<Guid>(VdcQueryType.GetVdsByVdsId,
GetVdsByVdsIdParameters.class);
Line 80: VDS entity = getEntity(hostResolver, true);
Line 81: if (incoming.isSetCluster() &&
(incoming.getCluster().isSetId() || incoming.getCluster().isSetName())) {
you breaking the use-case here, you should be checking that old_cluster !=
new_cluster
Line 82: Guid clusterId = lookupClusterId(incoming);
Line 83: performAction(VdcActionType.ChangeVDSCluster,
Line 84: new ChangeVDSClusterParameters(clusterId,
guid));
Line 85: }
--
To view, visit http://gerrit.ovirt.org/11947
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I93a423f01fd6b140482d17558e058604b6009a2a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: engine_3.2
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
