Yair Zaslavsky has posted comments on this change.
Change subject: engine: Support for gluster asynchronous tasks(WIP)
......................................................................
Patch Set 2: (1 inline comment)
Hi Gilad,
This is a great question.
The answers:
a. AsyncTaskManager is used to handle VDSM related tasks (i.e - "engine side"
of the VDSM async task manager).
b. AsyncTaskManager manages only SPM tasks and would be too complex to start
managing HSM tasks as well - IIUC , there is no concept of "SPM"/"DataCenter"
when it comes to Gluster.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTaskManager.java
Line 69: //get step from db for the corresponding gluster task
Line 70: List<Step> steps =
DbFacade.getInstance().getStepDao().getStepsByExternalId(taskId);
Line 71: //update status in step table
Line 72: for (Step step: steps) {
Line 73: step.setDescription(getTaskMessage(step,task));
Right, thanks.
Line 74: if (hasTaskCompleted(task)) {
Line 75: //ExecutionHandler.endTaskStep(step.getId(),
getJobCompletedStatus(task));
Line 76:
Line 77: step.markStepEnded(getJobCompletedStatus(task));
--
To view, visit http://gerrit.ovirt.org/11840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a56785edef091bce74e2b7b0ba9a3314f1397f1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
