Alon Bar-Lev has posted comments on this change.
Change subject: core: Non-plugin automatic invocation of console session
......................................................................
Patch Set 8: Looks good to me, but someone else must approve
(2 inline comments)
Some minor comments embedded. But looks OK.
....................................................
File
backend/manager/modules/root/src/main/java/org/ovirt/engine/core/GetAttachmentServlet.java
Line 34: response.setHeader("Cache-Control", "no-cache,
must-revalidate"); //disable caching HTTP/1.1
Line 35: response.setHeader("Expires", "Sat, 26 Jul 1997 05:00:00
GMT"); //disable caching HTTP/1.0
Line 36: }
Line 37:
Line 38: if (content == null) {
I think an exception is appropriate in this case.
Line 39: return;
Line 40: }
Line 41:
Line 42: if ("binary".equals(encodingType)) {
Line 40: }
Line 41:
Line 42: if ("binary".equals(encodingType)) {
Line 43:
response.getOutputStream().write(Base64.decodeBase64(content));
Line 44: } else {
I think we should check for 'plain' or 'text' and raise an exception if not
matching any supported value.
Line 45: response.getWriter().write(content);
Line 46:
Line 47: if (response.getWriter().checkError()) {
Line 48: throw new IOException("Error when writing to response
stream");
--
To view, visit http://gerrit.ovirt.org/11702
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18b9d2efad15f5e9bb98a8176112b721c810205f
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
