Laszlo Hornyak has posted comments on this change.

Change subject: engine: Version cleanup
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/VersionTest.java
Line 26:     }
Line 27: 
Line 28:     @Test
Line 29:     public void getValue() {
Line 30:         Assert.assertEquals(new Version(1, -1).getValue(),  "1");
Allon, would you prefer to remove this unit test?
Line 31:         Assert.assertEquals(new Version(1, 1).getValue(),  "1.1");
Line 32:         Assert.assertEquals(new Version(1, 1, 1).getValue(),  "1.1.1");
Line 33:     }


--
To view, visit http://gerrit.ovirt.org/12005
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5af4ed70e213d8bd410b813d32b137962574a2c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to