Yair Zaslavsky has posted comments on this change.
Change subject: tools : taskcleaner.sh utility returns always 0 as return code
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File backend/manager/tools/dbutils/taskcleaner.sh
Line 106:
Line 107: # Install taskcleaner procedures
Line 108: psql -U ${USERNAME} -h ${SERVERNAME} -p ${PORT} -f
./taskcleaner_sp.sql ${DATABASE} > /dev/null
Line 109: status =`echo $?`
Line 110: if [$status -gt 0]; then
Why not be on the safe side and check not equals instead?
Line 111: exit $status
Line 112: fi
Line 113:
Line 114: if [ "${TASK_ID}" != "" -o "${COMMAND_ID}" != "" -o "${CLEAR_ALL}" =
"true" -o "${CLEAR_COMPENSATION}" = "true" -o "${CLEAR_JOB_STEPS}" = "true" ];
then #delete operations block
--
To view, visit http://gerrit.ovirt.org/12103
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If0c61616e0c4962ee141baba7eda40341d4f721b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
