Eduardo has posted comments on this change.
Change subject: core: Add VDSM missing error messages.
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
IMHO the whole connectStoragePool error flow should be reviewed.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStoragePoolVDSCommand.java
Line 22: @Override
Line 23: protected void ProceedProxyReturnValue() {
Line 24: VdcBllErrors returnStatus =
GetReturnValueFromStatus(getReturnStatus());
Line 25: switch (returnStatus) {
Line 26: case Done:
Why Done is treated like an error?
Line 27: case StoragePoolMasterNotFound:
Line 28: case StoragePoolTooManyMasters:
Line 29: case StoragePoolWrongMaster:
Line 30: super.ProceedProxyReturnValue();
Line 30: super.ProceedProxyReturnValue();
Line 31: break;
Line 32: case ReleaseLockFailure:
Line 33: case AcquireHostIdFailure:
Line 34: case ReleaseHostIdFailure:
This errors are related to sanlock but can be related to master issues. Why
they are different?
Line 35: VDSExceptionBase outEx = new
VDSErrorException(String.format("Failed in vdscommand %1$s, error = %2$s",
Line 36: getCommandName(), getReturnStatus().mMessage));
Line 37: InitializeVdsError(returnStatus);
Line 38: getVDSReturnValue().setSucceeded(false);
--
To view, visit http://gerrit.ovirt.org/8958
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8395c75bbba1f66d08bcd9c21fdeacc7f5e6d4f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Eyal Edri <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
