Tomas Jelinek has posted comments on this change.
Change subject: webadmin: patterned pool names support
......................................................................
Patch Set 3: Looks good to me, approved
(2 inline comments)
Just small comments - more recommendations. No problem for me if you don't
agree.
....................................................
File
frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/PoolNameValidationTest.java
Line 7:
Line 8: public class PoolNameValidationTest {
Line 9:
Line 10: @Test
Line 11: public void testValidNonPatternName() {
No need to prefix all the test methods' names with the "test" - it was needed
in JUnit 3. In JUnit 4 it is just redundant to the @Test annotation.
Line 12: Assert.assertTrue(new
TestablePoolNameValidation().Validate("pool-T4534f").getSuccess());
//$NON-NLS-1$
Line 13: }
Line 14:
Line 15: @Test
Line 8: public class PoolNameValidationTest {
Line 9:
Line 10: @Test
Line 11: public void testValidNonPatternName() {
Line 12: Assert.assertTrue(new
TestablePoolNameValidation().Validate("pool-T4534f").getSuccess());
//$NON-NLS-1$
You could statically import the Assert.assertTrue and assertFalse.
Line 13: }
Line 14:
Line 15: @Test
Line 16: public void testNonValidNonPatternName() {
--
To view, visit http://gerrit.ovirt.org/11985
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d0a5c6c06150493c2359686c3958bf92b3f69f7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
