Mike Kolesnik has posted comments on this change.
Change subject: engine: Refactored code into NetworkValidator class
......................................................................
Patch Set 11: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/AddNetworkCommand.java
Line 62: }
Line 63:
Line 64: @Override
Line 65: public List<PermissionSubject> getPermissionCheckSubjects() {
Line 66: Network network = getNetwork();
This change is not really necessary, since you set the "StoragePoolId" in the
super class
Line 67: NGuid dataCenterId = network == null ? null :
network.getDataCenterId();
Line 68: return Collections.singletonList(new
PermissionSubject(dataCenterId == null ? null
Line 69: : dataCenterId.getValue(),
Line 70: VdcObjectType.StoragePool,
getActionType().getActionGroup()));
--
To view, visit http://gerrit.ovirt.org/10940
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf40d81f0481c6b6dec141a71363888dc9e9a941
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
